This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] disable golden check for Noto-rendered text #27612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
yjbanov
force-pushed
the
disable-ck-text-goldens
branch
from
dedf5fe to
88bdda0
Compare
zanderso
reviewed
Jul 21, 2021
| region: ui.Rect.fromLTRB(0, 0, testWidth, paragraphHeight + 20), | ||
| write: write, | ||
| ); | ||
| if (!kIssue86432Exists) { |
Member
There was a problem hiding this comment.
Should this be if (kIssue86432Exists)?
Contributor
Author
There was a problem hiding this comment.
You and me both! I actually did type if (kIssue86432Exists) initially, then thought about it and amended the commit, lol :)
zanderso
approved these changes
Jul 21, 2021
yjbanov
force-pushed
the
disable-ck-text-goldens
branch
from
88bdda0 to
945682f
Compare
mdebbar
approved these changes
Jul 21, 2021
yjbanov
force-pushed
the
disable-ck-text-goldens
branch
from
945682f to
2b019ee
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 21, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noto font comes from fonts.google.com making tests non-hermetic.
This caused two P0 issues already.
Fixes flutter/flutter#86756.