Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 945682f

Browse files
committed
[web] disable golden check for Noto-rendered text
1 parent 651dd48 commit 945682f

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

lib/web_ui/test/canvaskit/canvas_golden_test.dart

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ import 'package:web_engine_tester/golden_tester.dart';
1515

1616
import 'common.dart';
1717

18+
// TODO(yjbanov): tests that render using Noto are not hermetic, as those fonts
19+
// come from fonts.google.com, where fonts can change any time.
20+
// These tests are skipped.
21+
// https://github.com/flutter/flutter/issues/86432
22+
const bool kIssue86432Exists = true;
23+
1824
void main() {
1925
internalBootstrapBrowserTest(() => testMain);
2026
}
@@ -578,7 +584,7 @@ void testMain() {
578584
outerText: '← ↑ → ↓ ',
579585
innerText: '',
580586
);
581-
});
587+
}, skip: kIssue86432Exists);
582588

583589
test(
584590
'text style - foreground/background/color do not leak across paragraphs',
@@ -846,12 +852,14 @@ Future<void> testSampleText(String language, String text,
846852
paragraphHeight = paragraph.height;
847853
return recorder.endRecording();
848854
});
849-
await matchPictureGolden(
850-
'canvaskit_sample_text_$language.png',
851-
picture,
852-
region: ui.Rect.fromLTRB(0, 0, testWidth, paragraphHeight + 20),
853-
write: write,
854-
);
855+
if (!kIssue86432Exists) {
856+
await matchPictureGolden(
857+
'canvaskit_sample_text_$language.png',
858+
picture,
859+
region: ui.Rect.fromLTRB(0, 0, testWidth, paragraphHeight + 20),
860+
write: write,
861+
);
862+
}
855863
}
856864

857865
typedef ParagraphFactory = CkParagraph Function();

0 commit comments

Comments
 (0)