Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Build the robolectric tests by default for debug armv7 #27345

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Build the robolectric tests by default for debug armv7 #27345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35186fd
Build the robolectric tests by default for debug armv7
dnfield Jul 12, 2021
6369962
Fix dep cycle
dnfield Jul 12, 2021
2b23592
comment
dnfield Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion shell/platform/android/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ action("robolectric_tests") {
args += rebase_path(sources, root_build_dir)

deps = [
":android",
":android_jar",
":flutter_shell_java",
]
}
Expand Down Expand Up @@ -584,6 +584,12 @@ zip_bundle("android") {
]
deps += [ ":flutter_shell_native" ]
}

# We only run the robolectric tests for android_debug_unopt (arm CPU), and
# the target is relatively expensive to build.
if (flutter_runtime_mode == "debug" && current_cpu == "arm") {
Copy link

@blasten blasten Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the current cpu matter?

Copy link
Contributor Author

@dnfield dnfield Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This target is relatively slow to build, and we only run these tests on android_debug_unopt (armv7).

Copy link
Contributor Author

@dnfield dnfield Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean current v. target, this file refers to current elsewhere and it seems like current == target .. but current is not the "host" CPU

Copy link

@blasten blasten Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. could we add a comment?

Copy link
Contributor Author

@dnfield dnfield Jul 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

deps += [ ":robolectric_tests" ]
}
}

action("gen_android_javadoc") {
Expand Down