This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Build the robolectric tests by default for debug armv7 #27345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ahhh this doesn't work. |
Contributor
Author
|
The test target was depending on the top level android target rather than |
blasten
reviewed
Jul 12, 2021
| deps += [ ":flutter_shell_native" ] | ||
| } | ||
|
|
||
| if (flutter_runtime_mode == "debug" && current_cpu == "arm") { |
Contributor
Author
There was a problem hiding this comment.
This target is relatively slow to build, and we only run these tests on android_debug_unopt (armv7).
Contributor
Author
There was a problem hiding this comment.
If you mean current v. target, this file refers to current elsewhere and it seems like current == target .. but current is not the "host" CPU
dnfield
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
zanderso
approved these changes
Jul 13, 2021
Contributor
Author
|
Blocked on flutter/flutter#86326 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 13, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #27332
This target used to get built by default in run_tests.py, but we avoid doing that now for CI
Once this lands, we can remove the separate build step(s) for it from CI.