Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland: "android platform channels: moved to direct buffers for c <-> java interop" #26515

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Reland: "android platform channels: moved to direct buffers for c <-> java interop" #26515

merged 2 commits into from
Jun 1, 2021

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 1, 2021 •
edited
Loading

Relanding #26470

Added a null check that fixes the null pointer exception and added a test for it. You can see the fix in this patch: 457e8f9

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 1, 2021
@gaaclarke gaaclarke requested a review from jason-simmons June 1, 2021 17:12
@gaaclarke gaaclarke mentioned this pull request Jun 1, 2021
Merged
8 tasks
@gaaclarke gaaclarke requested a review from zanderso June 1, 2021 17:18
@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 1, 2021
@fluttergithubbot fluttergithubbot merged commit 6e3d533 into flutter:master Jun 1, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 1, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 1, 2021
@engine-flutter-autoroll
6e3d533 Reland: "android platform channels: moved to direct buffers f…
36b3be4 
…or c <-> java interop" (flutter/engine#26515)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2021
@engine-flutter-autoroll
6e3d533 Reland: "android platform channels: moved to direct buffers f…
ee97e65 
…or c <-> java interop" (flutter/engine#26515)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@gaaclarke
Reland: "android platform channels: moved to direct buffers for c <->…
f8241a2 
… java interop" (flutter#26515)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaaclarke @zanderso @fluttergithubbot