This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "android platform channels: moved to direct buffers for c <-> java interop" #26470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
May 28, 2021
|
If we want to fix forward, this probably just needs a null check on https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/plugin/common/BinaryCodec.java#L57 |
|
Let's go by the book and do the revert. The NPE is potentially just the first issue that the framework tree tests hit. |
|
Landing revert over resolved infra failures. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 28, 2021
…r c <-> java interop (flutter#26331)" (flutter/engine#26470)
|
Thanks, yea missing null check. If only we had null safety in java. I'll reland with a fix/test. |
This was referenced Jun 1, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
…java interop (flutter#26331)" (flutter#26470) This reverts commit a6eb224.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #26331
Errors on the framework tree
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/425/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20channels_integration_test/1340/overview