Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino changed the base branch from master to flutter-1.26-candidate.17 April 16, 2021 00:16
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla
Copy link

google-cla bot commented Apr 16, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@christopherfujino
Copy link
Contributor Author

overrode the clabot because i authored this commit.

Copy link
Contributor

@kf6gpe kf6gpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sroddy
Copy link

sroddy commented Apr 16, 2021

hi,
would it be possible to also cherry-pick this fix in upcoming stable?
4f6462b
It covers a critical crash and if you take a look at this #25506 (comment), @mkustermann also recommended to do so.

thanks

@christopherfujino
Copy link
Contributor Author

hi,
would it be possible to also cherry-pick this fix in upcoming stable?
4f6462b
It covers a critical crash and if you take a look at this #25506 (comment), @mkustermann also recommended to do so.

I would recommend following up on that issue about getting approved for a cherrypick. My role is to apply approved cherrypicks, I don't make the call :)

@kf6gpe
Copy link
Contributor

kf6gpe commented Apr 16, 2021

@sroddy Looking at the original issue (if I'm reading this right) --- flutter/flutter#79335 --- it was already cherrypicked.

@christopherfujino
Copy link
Contributor Author

Failures are the same as the previous build

@christopherfujino christopherfujino merged commit b09f014 into flutter:flutter-1.26-candidate.17 Apr 16, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch April 16, 2021 06:03
@sroddy
Copy link

sroddy commented Apr 17, 2021

@kf6gpe I might be be wrong but it looks like it was cherry-picked in beta but not in stable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants