Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Mar 31, 2021

Scheduled Cherrypicks

  • #76122 Web HTML renderer does not work with widgetspans
  • #75280 [web]: Dragging the "draggable" widget causes widget to freeze in the overlay layer

Known Failures

  • Linux & Mac Web Engine goldens diffs, same as previous build
  • build_and_test_linux_unopt_debug timed out after an hour, ignoring as the LUCI build succeeded.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Mar 31, 2021

Linux Web Framework tests is pulling the latest framework commit (d377c1baeda6b802be16efdf9ab770bbc8cabe9c), I'm guessing that explains the compilation failure? https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8851210506222927856/+/steps/run_web_integration_tests/0/stdout

@mdebbar WDYT?

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I re-ran build_and_test_linux_unopt_debug since it's not showing what the failure is, and it's known to be flaky in Cirrus.

@christopherfujino christopherfujino merged commit 2dce470 into flutter:flutter-1.26-candidate.17 Mar 31, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.26-candidate.17 branch March 31, 2021 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants