This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Fixes android voice access delete text, redo, and undo action" #25289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. (flutter#25050)" This reverts commit 4c6abc1.
xster
approved these changes
Mar 29, 2021
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
flutter#25289) * Reland "Fixes android voice access delete text, redo, and undo actions. (flutter#25050)" This reverts commit 4c6abc1. * fix condition
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
flutter#25289) * Reland "Fixes android voice access delete text, redo, and undo actions. (flutter#25050)" This reverts commit 4c6abc1. * fix condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pr was reverted due to internal lint error and framework post submit integration test.
The only change from the previous pr is fixing the lint, which is in the second commit.
This is the second step of flutter/flutter#77965 (comment)
flutter/flutter#77965
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.