This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixes android voice access delete text, redo, and undo actions. #25050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
chunhtai
commented
Mar 18, 2021
| case AccessibilityNodeInfo.MOVEMENT_GRANULARITY_LINE: | ||
| case AccessibilityNodeInfo.MOVEMENT_GRANULARITY_PARAGRAPH: | ||
| case AccessibilityNodeInfo.MOVEMENT_GRANULARITY_PAGE: | ||
| return true; |
Contributor
Author
There was a problem hiding this comment.
We don't have semantics action for these actions. I feel weird to add them, too, because they aren't really going to be used. voice access only care about the action return true and the semantics node gets updated immediately, which is done by the predictCursorMovement.
If we do want to add them, I feel we should just merge all the cursor movement action into one semantics action that takes in granularity and direction.
xster
approved these changes
Mar 23, 2021
| break; | ||
| case AccessibilityNodeInfo.MOVEMENT_GRANULARITY_WORD: | ||
| if (forward && node.textSelectionExtent < node.value.length()) { | ||
| Pattern pattern = Pattern.compile("[^a-zA-Z0-9](\\b)"); |
Member
There was a problem hiding this comment.
this will only work for latin alphabet languages right?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
Member
|
I believe this caused a post-submit engine->framework test failure flutter/flutter#79118 |
Contributor
|
This also breaks Google internal compilation. test/OCL:365108065:BASE:365285587:1616804402433:d72060c2 |
xster
reviewed
Mar 29, 2021
| Pattern pattern = Pattern.compile("\\p{L}(\\b)"); | ||
| Matcher result = pattern.matcher(node.value.substring(node.textSelectionExtent)); | ||
| // we discard the first result because we want to find the "next" word | ||
| if (result.find() && result.find()) { |
Member
There was a problem hiding this comment.
the test failure is from this condition and'ing the same expression twice
Contributor
Author
There was a problem hiding this comment.
The lint does not consider the side affect of calling the condition. Not sure what is the correct way of writing this..
chunhtai
added a commit
to chunhtai/engine
that referenced
this pull request
Mar 29, 2021
…s. (flutter#25050)" This reverts commit 8d73893.
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2021
chunhtai
added a commit
to chunhtai/engine
that referenced
this pull request
Mar 29, 2021
…s. (flutter#25050)" This reverts commit 4c6abc1.
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
…ter#25050) * Fixes android voice access delete text, redo, and undo actions * account for unicode
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
…s. (flutter#25050)" (flutter#25286) This reverts commit 8d73893.
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
flutter#25289) * Reland "Fixes android voice access delete text, redo, and undo actions. (flutter#25050)" This reverts commit 4c6abc1. * fix condition
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
…ter#25050) * Fixes android voice access delete text, redo, and undo actions * account for unicode
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
…s. (flutter#25050)" (flutter#25286) This reverts commit 8d73893.
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
flutter#25289) * Reland "Fixes android voice access delete text, redo, and undo actions. (flutter#25050)" This reverts commit 4c6abc1. * fix condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#77965
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.