Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Highlight VSync support for embedders #25247

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Highlight VSync support for embedders #25247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions shell/common/vsync_waiter_fallback.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "flutter/shell/common/vsync_waiter_fallback.h"

#include "flutter/fml/logging.h"
#include "flutter/fml/trace_event.h"

namespace flutter {
namespace {
Expand All @@ -27,6 +28,8 @@ VsyncWaiterFallback::~VsyncWaiterFallback() = default;

// |VsyncWaiter|
void VsyncWaiterFallback::AwaitVSync() {
TRACE_EVENT0("flutter", "VSYNC");
Copy link
Member

@chinmaygarde chinmaygarde Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a TRACE_INSTANT0. It is not meant to be a slice I don't think.

Copy link
Contributor Author

@iskakaushik iskakaushik Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following what's being done on: https://github.com/flutter/engine/blob/master/shell/platform/android/vsync_waiter_android.cc#L47 and https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.mm#L71 as I wasn't sure how catapult expects these. I will investigate changing it to an instant.


constexpr fml::TimeDelta kSingleFrameInterval =
fml::TimeDelta::FromSecondsF(1.0 / 60.0);

Expand Down