This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Highlight VSync support for embedders #25247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome Trace viewer treats events labeled "VSYNC" as special and highlights them (when the "Highlight Vsync" checkbox is enabled). Ideally VSYNC events are generated by the host system at their source. System VSYNC events are indeed present in full-system systraces. Flutter-level traces (as seen in Observatory/Flutter devtools) do not contain the system VSYNC events, so we rely on the engine to generate them (as close to where they would be generated by the system ideally).
zanderso
approved these changes
Mar 25, 2021
iskakaushik
added
the
waiting for tree to go green
chinmaygarde
approved these changes
Mar 25, 2021
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
I also suggest (in another patch is fine) adding this trace around embedder provided vsync callback trampolines. That way, all existing embedders that wire up vsync correctly instead of falling back to a timer will get this well.
The only argument I can think of against doing this for embedder is if they want to do it themselves via FlutterEngineTraceEventInstant().
|
|
||
| // |VsyncWaiter| | ||
| void VsyncWaiterFallback::AwaitVSync() { | ||
| TRACE_EVENT0("flutter", "VSYNC"); |
Member
There was a problem hiding this comment.
Shouldn't this be a TRACE_INSTANT0. It is not meant to be a slice I don't think.
Contributor
Author
There was a problem hiding this comment.
I was following what's being done on: https://github.com/flutter/engine/blob/master/shell/platform/android/vsync_waiter_android.cc#L47 and https://github.com/flutter/engine/blob/master/shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.mm#L71 as I wasn't sure how catapult expects these. I will investigate changing it to an instant.
iskakaushik
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 29, 2021
chandarrengoog
pushed a commit
to chandarrengoog/engine
that referenced
this pull request
Mar 30, 2021
Chrome Trace viewer treats events labeled "VSYNC" as special and highlights them (when the "Highlight Vsync" checkbox is enabled). Ideally VSYNC events are generated by the host system at their source. System VSYNC events are indeed present in full-system systraces. Flutter-level traces (as seen in Observatory/Flutter devtools) do not contain the system VSYNC events, so we rely on the engine to generate them (as close to where they would be generated by the system ideally).
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Chrome Trace viewer treats events labeled "VSYNC" as special and highlights them (when the "Highlight Vsync" checkbox is enabled). Ideally VSYNC events are generated by the host system at their source. System VSYNC events are indeed present in full-system systraces. Flutter-level traces (as seen in Observatory/Flutter devtools) do not contain the system VSYNC events, so we rely on the engine to generate them (as close to where they would be generated by the system ideally).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome Trace viewer treats events labeled "VSYNC" as special and highlights them (when the "Highlight Vsync" checkbox is enabled). We do this for ios and android already, this PR also does this for fallback vsync waiters which are used by embedders by default.