This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not use eglQuerySurface to query surface dimensions #24682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
knopp
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
#24428 attempted to make surface resizing less expensive by using ANGLE's automatic resizing instead of manually destroying and then re-creating the surface. This caused some issues: 1. Flutter's surface size synchronization logic broke: #24682 2. Resizing frameless windows caused the content to wiggle: flutter/flutter#76465 The second issue caused the automatic resizing change to be reverted. However, the first fix was not reverted resulting in an incorrect comment. Relanding this resizing performance improvement is tracked by flutter/flutter#79427
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#76465
This alleviates some of the resize issues caused by switch to Angle managing surface size.
During window resizing, Angle may resize the surface on its own, before flutter asks it to. This happens because without
EGL_FIXED_SIZE_ANGLEAngle checks the window dimensions during everyeglSwapBufferscall. This in turns breaks flutter resize synchronization process, which does not expectAngleSurfaceManager::GetSurfaceDimensionsreturning different dimensions than previously requested byAngleSurfaceManager ::ResizeSurface.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.