Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Windows: Improve window resizing #24428

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Windows: Improve window resizing #24428

merged 1 commit into from
Feb 18, 2021

Conversation

@clarkezone
Copy link

@clarkezone clarkezone commented Feb 16, 2021

This PR improves window resizing on Windows in the following ways:

  1. For all cases (win32, UWP CoreWindow, UWP Compositor), rather than destroying and creating a new render surface for each resize step, instead resize the buffers by calling eglPostSubBufferNV which internally calls ResizeBuffers on the underlying SwapChain which is preferable and far less expensive.
  2. This change also fixes UWP resizing for both CoreWindow and Compositor modes.

flutter/flutter#14967
flutter/flutter#70198

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@clarkezone clarkezone self-assigned this Feb 16, 2021
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 16, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@clarkezone clarkezone mentioned this pull request Feb 16, 2021
Closed
4 tasks
iskakaushik
iskakaushik approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 18, 2021
@fluttergithubbot fluttergithubbot merged commit 1f08def into flutter:master Feb 18, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
1f08def Improve resize (flutter/engine#24428)
19bd250
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
1f08def Improve resize (flutter/engine#24428)
e7b1ead
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
1f08def Improve resize (flutter/engine#24428)
9673ca4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
1f08def Improve resize (flutter/engine#24428)
f1e2496
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
1f08def Improve resize (flutter/engine#24428)
bf7475d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2021
@engine-flutter-autoroll
1f08def Improve resize (flutter/engine#24428)
e0fd054
@knopp knopp mentioned this pull request Feb 20, 2021
Closed
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@clarkezone @hjfreyer
Improve resize (flutter#24428)
574f9ff
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@clarkezone @chriscraws
Improve resize (flutter#24428)
71eb7ee
@clarkezone clarkezone mentioned this pull request Mar 31, 2021
Open
clarkezone added a commit to clarkezone/engine that referenced this pull request Mar 31, 2021
@clarkezone
Revert flutter#24428
0d7c902
@clarkezone clarkezone mentioned this pull request Mar 31, 2021
Merged
9 tasks
clarkezone added a commit that referenced this pull request Apr 2, 2021
@clarkezone
Revert #24428 (#25319)
3cd5caa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2021
@engine-flutter-autoroll
3cd5caa Revert flutter/engine#24428 (flutter/engine#25319)
3ab8b5a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2021
@engine-flutter-autoroll
3cd5caa Revert flutter/engine#24428 (flutter/engine#25319)
110ca18
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@clarkezone @duanqz
Revert flutter#24428 (flutter#25319)
11cfa37
@loic-sharma loic-sharma mentioned this pull request Dec 21, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Dec 21, 2023
@loic-sharma
[Windows] Fix incorrect surface manager comment (#49335)
b0694c5 
#24428 attempted to make surface resizing less expensive by using ANGLE's automatic resizing instead of manually destroying and then re-creating the surface. This caused 
some issues:

1. Flutter's surface size synchronization logic broke: #24682
2. Resizing frameless windows caused the content to wiggle: flutter/flutter#76465

The second issue caused the automatic resizing change to be reverted. However, the first fix was not reverted resulting in an incorrect comment.

Relanding this resizing performance improvement is tracked by flutter/flutter#79427
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@cbracken cbracken Awaiting requested review from cbracken

@knopp knopp Awaiting requested review from knopp

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@clarkezone clarkezone

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@clarkezone @iskakaushik @chinmaygarde @googlebot @fluttergithubbot