Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Declare a constant for the bit index of the force_strut_height flag value #24675

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Declare a constant for the bit index of the force_strut_height flag value #24675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/ui/text/paragraph_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ const int sFontSizeIndex = 3;
const int sHeightIndex = 4;
const int sLeadingIndex = 5;
const int sForceStrutHeightIndex = 6;
const int sForceStrutHeightValueIndex = 7;

const int sFontWeightMask = 1 << sFontWeightIndex;
const int sFontStyleMask = 1 << sFontStyleIndex;
Expand All @@ -128,6 +129,7 @@ const int sFontSizeMask = 1 << sFontSizeIndex;
const int sHeightMask = 1 << sHeightIndex;
const int sLeadingMask = 1 << sLeadingIndex;
const int sForceStrutHeightMask = 1 << sForceStrutHeightIndex;
const int sForceStrutHeightValueMask = 1 << sForceStrutHeightValueIndex;

} // namespace

Expand Down Expand Up @@ -215,8 +217,8 @@ void decodeStrut(Dart_Handle strut_data,
paragraph_style.strut_leading = float_data[float_count++];
}
if (mask & sForceStrutHeightMask) {
// The boolean is stored as the last bit in the bitmask.
paragraph_style.force_strut_height = (mask & 1 << 7) != 0;
paragraph_style.force_strut_height =
(mask & sForceStrutHeightValueMask) != 0;
}

if (mask & sFontFamilyMask) {
Expand Down