Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Declare a constant for the bit index of the force_strut_height flag value #24675

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Declare a constant for the bit index of the force_strut_height flag value #24675

merged 1 commit into from
Feb 27, 2021

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Feb 27, 2021

No description provided.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 27, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 27, 2021
LongCatIsLooong
LongCatIsLooong approved these changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we need 2 bits for force_strut_height? When it's set to null in StrutStyle it defaults to false. Would it be possible to just use 1 bit?

@jason-simmons
Copy link
Member Author

jason-simmons commented Feb 27, 2021

@GaryQian Is there a difference between forceStrutHeight: null and forceStrutHeight: false in the ParagraphStyle?

@jason-simmons jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 27, 2021
@fluttergithubbot fluttergithubbot merged commit 06957f3 into flutter:master Feb 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2021
@engine-flutter-autoroll
06957f3 Declare a constant for the bit index of the force_strut_heigh…
ba9bfae 
…t flag value (flutter/engine#24675)
@GaryQian
Copy link
Contributor

GaryQian commented Feb 28, 2021

I believe null and false behave the same.

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@jason-simmons @hjfreyer
Declare a constant for the bit index of the force_strut_height flag v…
e2d25d9 
…alue (flutter#24675)
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@jason-simmons @chriscraws
Declare a constant for the bit index of the force_strut_height flag v…
47e9354 
…alue (flutter#24675)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jason-simmons @GaryQian @LongCatIsLooong @fluttergithubbot