Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Feb 19, 2021

Reland #24288, reverted in #24486

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong
Copy link
Contributor Author

hi @blasten I'd like to verify the PR works on SDK27 and below, for that I need "org.robolectric:android-all:8.0.0_r4-robolectric-r1". Should I proceed to the CIPD step to add the jar to android_embedding_dependencies?

@chinmaygarde chinmaygarde requested a review from blasten March 4, 2021 22:40
@chinmaygarde
Copy link
Member

Ping @blasten. Can you answer @LongCatIsLooong's please? Looks like this PR is stalled in the meantime.

@chinmaygarde
Copy link
Member

@LongCatIsLooong: @blasten is on leave for a bit so I don't think we'll be able to get an answer just yet. I think adding the jar to android_embedding_dependencies via a CIPD step is fine though. Let's do that if it unblocks you.

@chinmaygarde
Copy link
Member

@LongCatIsLooong Any progress? If you are blocked on this, what can I do to get this unstuck? If you are working on other things, lets close this in the meantime and reopen when it is ready for review.

@LongCatIsLooong LongCatIsLooong deleted the reland-24288 branch March 23, 2021 04:28
@LongCatIsLooong
Copy link
Contributor Author

This is no longer needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants