This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Android Text Input] Remove Samsung restart input workaround for newer Samsung keyboards" #24486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Feb 18, 2021
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Is the plan to come back to this without using getLongVersionCode?
Contributor
Author
|
IIRC there's a deprecated version of |
LongCatIsLooong
added
the
waiting for tree to go green
LongCatIsLooong
deleted the
revert-24288-remove-samsung-input-restart
branch
Contributor
|
Potentially useful example, which I found before realizing that this was coming from the engine, not a plugin: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 19, 2021
…karound for newer Samsung keyboards (flutter#24288)" (flutter/engine#24486)
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…for newer Samsung keyboards (flutter#24288)" (flutter#24486)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24288 as per #24288 (comment).