This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] specify all defines used for html, ck, auto rendering modes #23433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Jan 5, 2021
| "--libraries-file", | ||
| "org-dartlang-sdk:///flutter_web_sdk/libraries.json", | ||
| "--inline-source-map", | ||
| "-DFLUTTER_WEB_USE_SKIA=true", |
Contributor
Author
There was a problem hiding this comment.
Does autodetect use skia=true?
Contributor
There was a problem hiding this comment.
You can remove this. It doesn't matter once FLUTTER_WEB_AUTO_DETECT is specified.
Contributor
There was a problem hiding this comment.
autodetect has higher precedence, it doesn't check skia at that point.
Contributor
Author
There was a problem hiding this comment.
OK, I'll leave it as set just so it is easier to change in the future.
ferhatb
approved these changes
Jan 5, 2021
jonahwilliams
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 6, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 7, 2021
yjbanov
pushed a commit
to yjbanov/engine
that referenced
this pull request
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow changing the default value of the flutter web rendering backends in debug mode by specifying all dart defines. Also updates the BUILD.gn comments to be clearer on what is getting built.