Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f6d99ea

Browse files
author
Jonah Williams
authored
[web] specify all defines used for html, ck, auto rendering modes (#23433)
1 parent f095a77 commit f6d99ea

File tree

1 file changed

+16
-8
lines changed

1 file changed

+16
-8
lines changed

web_sdk/BUILD.gn

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ copy("web_ui_library") {
100100
outputs = [ "$root_out_dir/flutter_web_sdk/{{source_file_part}}" ]
101101
}
102102

103-
# Compile the DDC SDK's summary.
103+
# Compile the unsound DDC SDK's summary.
104104
prebuilt_dart_action("flutter_dartdevc_kernel_sdk_outline") {
105105
deps = [
106106
"//third_party/dart:create_sdk",
@@ -141,7 +141,7 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_outline") {
141141
]
142142
}
143143

144-
# Compiles the DDC SDK's JS code.
144+
# Compiles the unsound html only renderer.
145145
prebuilt_dart_action("flutter_dartdevc_kernel_sdk") {
146146
deps = [
147147
"//third_party/dart:create_sdk",
@@ -181,6 +181,8 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk") {
181181
"--libraries-file",
182182
"org-dartlang-sdk:///flutter_web_sdk/libraries.json",
183183
"--inline-source-map",
184+
"-DFLUTTER_WEB_USE_SKIA=false",
185+
"-DFLUTTER_WEB_AUTO_DETECT=false",
184186
"--modules",
185187
"amd",
186188
"-o",
@@ -192,7 +194,7 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk") {
192194
]
193195
}
194196

195-
# Compiles the DDC CanvasKit SDK's JS code.
197+
# Compiles the unsound canvaskit only renderer.
196198
prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk") {
197199
deps = [
198200
"//third_party/dart:create_sdk",
@@ -233,6 +235,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk") {
233235
"org-dartlang-sdk:///flutter_web_sdk/libraries.json",
234236
"--inline-source-map",
235237
"-DFLUTTER_WEB_USE_SKIA=true",
238+
"-DFLUTTER_WEB_AUTO_DETECT=false",
236239
"--modules",
237240
"amd",
238241
"-o",
@@ -246,7 +249,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk") {
246249
]
247250
}
248251

249-
# Compiles the DDC CanvasKit and Html SDK's JS code.
252+
# Compiles the unsound autodetect renderer.
250253
prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk") {
251254
deps = [
252255
"//third_party/dart:create_sdk",
@@ -286,6 +289,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk") {
286289
"--libraries-file",
287290
"org-dartlang-sdk:///flutter_web_sdk/libraries.json",
288291
"--inline-source-map",
292+
"-DFLUTTER_WEB_USE_SKIA=true",
289293
"-DFLUTTER_WEB_AUTO_DETECT=true",
290294
"--modules",
291295
"amd",
@@ -300,7 +304,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk") {
300304
]
301305
}
302306

303-
# Compiles the DDC SDK's JS code for null safety.
307+
# Compiles the sound html only renderer.
304308
prebuilt_dart_action("flutter_dartdevc_kernel_sdk_sound") {
305309
deps = [
306310
"//third_party/dart:create_sdk",
@@ -341,6 +345,8 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_sound") {
341345
"--libraries-file",
342346
"org-dartlang-sdk:///flutter_web_sdk/libraries.json",
343347
"--inline-source-map",
348+
"-DFLUTTER_WEB_USE_SKIA=false",
349+
"-DFLUTTER_WEB_AUTO_DETECT=false",
344350
"--modules",
345351
"amd",
346352
"-o",
@@ -353,7 +359,7 @@ prebuilt_dart_action("flutter_dartdevc_kernel_sdk_sound") {
353359
]
354360
}
355361

356-
# Compiles the DDC CanvasKit SDK's JS code for null safety.
362+
# Compiles the sound canvaskit only renderer.
357363
prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk_sound") {
358364
deps = [
359365
"//third_party/dart:create_sdk",
@@ -395,6 +401,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk_sound") {
395401
"org-dartlang-sdk:///flutter_web_sdk/libraries.json",
396402
"--inline-source-map",
397403
"-DFLUTTER_WEB_USE_SKIA=true",
404+
"-DFLUTTER_WEB_AUTO_DETECT=false",
398405
"--modules",
399406
"amd",
400407
"-o",
@@ -408,7 +415,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_kernel_sdk_sound") {
408415
]
409416
}
410417

411-
# Compiles the DDC CanvasKit and Html SDK's JS code for null safety.
418+
# Compiles the sound autodetect renderer.
412419
prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk_sound") {
413420
deps = [
414421
"//third_party/dart:create_sdk",
@@ -449,6 +456,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk_sound") {
449456
"--libraries-file",
450457
"org-dartlang-sdk:///flutter_web_sdk/libraries.json",
451458
"--inline-source-map",
459+
"-DFLUTTER_WEB_USE_SKIA=false",
452460
"-DFLUTTER_WEB_AUTO_DETECT=true",
453461
"--modules",
454462
"amd",
@@ -463,7 +471,7 @@ prebuilt_dart_action("flutter_dartdevc_canvaskit_html_kernel_sdk_sound") {
463471
]
464472
}
465473

466-
# Compile the DDC SDK's summary.
474+
# Compile the sound DDC SDK's summary.
467475
prebuilt_dart_action("flutter_dartdevc_kernel_sdk_outline_sound") {
468476
deps = [
469477
"//third_party/dart:create_sdk",

0 commit comments

Comments
 (0)