Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Dec 9, 2020

@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master December 9, 2020 00:06
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@cyanglaz cyanglaz changed the base branch from master to flutter-1.22-candidate.12 December 9, 2020 00:06
Chris Yang added 2 commits December 8, 2020 16:08
@christopherfujino
Copy link
Contributor

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Dec 9, 2020

@christopherfujino it was a wrong fix, pushed again.

@christopherfujino
Copy link
Contributor

I triggered another LED build https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/fujino_google.com/342a1f37debe81e0f1ee1bcf32c10620f08bb403abcf267ebe145f55cb3a6424/+/annotations, and I'm seeing a different failure, this time in "Scenario App Integration Tests". I will follow up tomorrow.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Dec 9, 2020

@christopherfujino The test didn't fail locally, It is possibly a flake. Could you trigger another build and check?

@christopherfujino
Copy link
Contributor

@christopherfujino The test didn't fail locally, It is possibly a flake. Could you trigger another build and check?

Will do. cc @blasten in case this is expected to fail.

@christopherfujino
Copy link
Contributor

Ok, it passed on a re-run.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

has the same CI failures as the previous PR on branch #22930, thus I am merging this to fix the Linux Android AOT Engine build.

@christopherfujino
Copy link
Contributor

Mac Stable iOS Engine flaked post-submit, to fix, cherrypick https://github.com/flutter/engine/pull/22247/files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants