Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Nov 13, 2020

#22435 Description

Implement settings channel for the Linux shell

Related Issues

flutter/flutter#65591

Tests

Tests added to confirm settings are sent on engine startup.

Manually tested by changing the following in gnome-control-center:

  • Accessibility > Large Text (sets text scale to 1.25)
  • Date & Time > Time Format (sets clock to 12/24hr).
  • Appearance > Window colors (sets brightness to dark. Ubuntu extension, use gnome-tweak-tool for other systems).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@robert-ancell
Copy link
Contributor Author

robert-ancell commented Nov 13, 2020

Due to a bug in the Flutter snap if you try the tests the setting values never change from their initial value. The workaround is to run the binary directly, and the fix will be in the snap.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit testing that the message is being sent on startup; see #22323 for an example.

@chinmaygarde
Copy link
Member

@robert-ancell Any progress on the unit-tests requested by @stuartmorgan ?

@robert-ancell
Copy link
Contributor Author

I'm currently working on a branch to add some base engine tests then will update this one with the new test for the settings channel.

@robert-ancell
Copy link
Contributor Author

This includes the change in #22900, which should probably land before this one.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-ancell robert-ancell merged commit 90d1f05 into flutter:master Jan 4, 2021
@robert-ancell robert-ancell deleted the linux-shell-fl-settings-plugin branch January 4, 2021 23:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2021
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 5, 2021
yjbanov pushed a commit to yjbanov/engine that referenced this pull request Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants