-
Notifications
You must be signed in to change notification settings - Fork 6k
Implement settings channel for the Linux shell #22486
Implement settings channel for the Linux shell #22486
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Due to a bug in the Flutter snap if you try the tests the setting values never change from their initial value. The workaround is to run the binary directly, and the fix will be in the snap. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit testing that the message is being sent on startup; see #22323 for an example.
|
@robert-ancell Any progress on the unit-tests requested by @stuartmorgan ? |
|
I'm currently working on a branch to add some base engine tests then will update this one with the new test for the settings channel. |
|
This includes the change in #22900, which should probably land before this one. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implement settings channel for the Linux shell Fixes flutter/flutter#65591
Implement settings channel for the Linux shell Fixes flutter/flutter#65591
#22435 Description
Implement settings channel for the Linux shell
Related Issues
flutter/flutter#65591
Tests
Tests added to confirm settings are sent on engine startup.
Manually tested by changing the following in gnome-control-center:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.