Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

chingjun
Copy link
Contributor

@chingjun chingjun commented Feb 6, 2020

No description provided.

@chingjun chingjun requested a review from dnfield February 6, 2020 02:01
@auto-assign auto-assign bot requested a review from flar February 6, 2020 02:01
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dnfield
Copy link
Contributor

dnfield commented Feb 6, 2020

Linux host test is a flake.

@chingjun chingjun added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 6, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 6, 2020
@chingjun chingjun merged commit f06ebba into flutter:master Feb 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 6, 2020
dnfield pushed a commit to flutter/flutter that referenced this pull request Feb 7, 2020
* d5442b8 Roll src/third_party/skia bc3307c395e2..ebc00f97fab1 (21 commits) (flutter/engine#16429)

* 76b291a Added a plugin method that gets called when the engine is about to be deleted (flutter/engine#16336)

* 07f25c5 fix bad reference to maxDiffRatePercent (flutter/engine#16440)

* 41d50c2 Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365)

* f25d325 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425)

* 473f559 Suppress some deprecation warnings on Windows (flutter/engine#16416)

* 2e34ad6 Roll fuchsia/sdk/core/mac-amd64 from ubThi... to fvWgE... (flutter/engine#16454)

* 47c02e6 Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456)

* 3d1b112 Roll buildroot (flutter/engine#16419)

* 28e6637 Add explicit casts to printing of function pointers (flutter/engine#16370)

* 9ad81da Wrap strdup to use compliant name on Windows (flutter/engine#16372)

* 9708e52 Roll rapidjson (flutter/engine#16347)

* f06ebba Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442)

* e530376 Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457)

* 4cc41ae Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459)

* 2f233ed Roll src/third_party/skia 4721e067812f..f6e3eaf05150 (1 commits) (flutter/engine#16461)

* b0b0ed8 Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463)

* 7fea936 Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466)

* 001b3a0 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471)

* f3ce90e Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469)
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants