This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" #16365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
force-pushed
the
reland_position_for_offset
branch
from
b625681 to
1149c9d
Compare
mdebbar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2020
… multi-line paragraphs" (flutter/engine#16365)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2020
… multi-line paragraphs" (flutter/engine#16365)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2020
… multi-line paragraphs" (flutter/engine#16365)
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2020
* d5442b8 Roll src/third_party/skia bc3307c395e2..ebc00f97fab1 (21 commits) (flutter/engine#16429) * 76b291a Added a plugin method that gets called when the engine is about to be deleted (flutter/engine#16336) * 07f25c5 fix bad reference to maxDiffRatePercent (flutter/engine#16440) * 41d50c2 Reland #16206: "[web] Correct getPositionForOffset for multi-line paragraphs" (flutter/engine#16365) * f25d325 [fuchsia] change kMaxFramesInFlight to 3 (flutter/engine#16425) * 473f559 Suppress some deprecation warnings on Windows (flutter/engine#16416) * 2e34ad6 Roll fuchsia/sdk/core/mac-amd64 from ubThi... to fvWgE... (flutter/engine#16454) * 47c02e6 Roll src/third_party/skia ebc00f97fab1..cbf79b95c2d4 (4 commits) (flutter/engine#16456) * 3d1b112 Roll buildroot (flutter/engine#16419) * 28e6637 Add explicit casts to printing of function pointers (flutter/engine#16370) * 9ad81da Wrap strdup to use compliant name on Windows (flutter/engine#16372) * 9708e52 Roll rapidjson (flutter/engine#16347) * f06ebba Include <memory> in hb_wrapper.h because unique_ptr is used. (flutter/engine#16442) * e530376 Roll fuchsia/sdk/core/linux-amd64 from VJv0H... to A9STP... (flutter/engine#16457) * 4cc41ae Roll src/third_party/skia cbf79b95c2d4..4721e067812f (1 commits) (flutter/engine#16459) * 2f233ed Roll src/third_party/skia 4721e067812f..f6e3eaf05150 (1 commits) (flutter/engine#16461) * b0b0ed8 Roll src/third_party/skia f6e3eaf05150..cc21d0c1f2ce (1 commits) (flutter/engine#16463) * 7fea936 Roll src/third_party/skia cc21d0c1f2ce..116b33e8ab21 (3 commits) (flutter/engine#16466) * 001b3a0 Roll src/third_party/skia 116b33e8ab21..7f36405ea3ec (3 commits) (flutter/engine#16471) * f3ce90e Reset width/height before deallocation for Safari allocation bug. (flutter/engine#16469)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
… multi-line paragraphs" (flutter#16365)" This reverts commit edd07bd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally landed in: #16206
Reverted in: #16268
This PR has the same content as the reverted PR + the fix. The fix can be reviewed separately in the second commit labeled "Fix issue of previous PR".
Fixes flutter/flutter#50101