-
Notifications
You must be signed in to change notification settings - Fork 111
Add diagrams for Canvas.drawArc and Path.addArc #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagrams for Canvas.drawArc and Path.addArc #197
Conversation
|
Hey, that's a cool diagram! When I look at the counter clockwise one, it seems like the black dotted line around the outside is escaping the square. Maybe some transparency and color would help to show the start angle, instead of the dashed lines? Also, I feel like an arrow on or near the blue line (or even both the start angle and arc lines) might not be a bad idea to show which direction is "positive" on the arc. |
|
Oh, that's much nicer! Could you just do one more small thing: just shrink the overall size of the arcs so that they all (including the black one) fit inside of the grey box with just a little padding? The black dotted arc in the CCW one still looks like it's outside the box. |
…s-for-api-docs into pixeltoast/arc-diagrams
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This is fantastic. |







This PR adds diagrams for arcs 😺
canvas_draw_arc:

path_add_arc.png:

path_add_arc_ccw.png:
