Skip to content

Conversation

@pingbird
Copy link
Member

This PR adds diagrams for arcs 😺

canvas_draw_arc:
canvas_draw_arc

path_add_arc.png:
path_add_arc

path_add_arc_ccw.png:
path_add_arc_ccw

@pingbird pingbird requested a review from gspencergoog August 25, 2022 23:49
@gspencergoog
Copy link
Contributor

Hey, that's a cool diagram!

When I look at the counter clockwise one, it seems like the black dotted line around the outside is escaping the square.

Maybe some transparency and color would help to show the start angle, instead of the dashed lines?

Also, I feel like an arrow on or near the blue line (or even both the start angle and arc lines) might not be a bad idea to show which direction is "positive" on the arc.

@pingbird
Copy link
Member Author

New version with arrows and fixed text alignment:

canvas_draw_arc

path_add_arc

path_add_arc_ccw

@gspencergoog
Copy link
Contributor

Oh, that's much nicer! Could you just do one more small thing: just shrink the overall size of the arcs so that they all (including the black one) fit inside of the grey box with just a little padding? The black dotted arc in the CCW one still looks like it's outside the box.

@pingbird
Copy link
Member Author

Thank you for all the good feedback! it looks much better now 😄

canvas_draw_arc
path_add_arc
path_add_arc_ccw

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

OK, the diagrams look great now.
Thanks for adding these!

@gspencergoog gspencergoog merged commit 3c6ed40 into flutter:master Aug 27, 2022
@Hixie
Copy link
Contributor

Hixie commented Sep 3, 2022

This is fantastic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants