Skip to content

Commit 3c6ed40

Browse files
authored
Add diagrams for Canvas.drawArc and Path.addArc (#197)
This PR adds diagrams for arcs 😺
1 parent 40d0901 commit 3c6ed40

File tree

10 files changed

+671
-4
lines changed

10 files changed

+671
-4
lines changed

assets/dart-ui/canvas_draw_arc.png

27.4 KB
Loading

assets/dart-ui/path_add_arc.png

27 KB
Loading
28.9 KB
Loading

bin/generate.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,9 @@ class DiagramGenerator {
313313
.where((File input) => path.basename(input.path) == 'error.log')
314314
.toList();
315315

316-
if (errorFiles.length != 1)
316+
if (errorFiles.length != 1) {
317317
throw GeneratorException('Subprocess did not complete cleanly!');
318+
}
318319

319320
print('Processing ${inputFiles.length - 1} files...');
320321

bin/pubspec.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ dependencies:
88
process_runner: ">=4.0.0 <5.0.0"
99

1010
dev_dependencies:
11+
args: ^2.3.1
1112
analyzer: ^4.1.0
1213
test: ^1.16.8
14+
path: ^1.8.0
15+
process: ^4.2.1
1316

1417
environment:
1518
sdk: ">=2.17.0-0 <3.0.0"
16-

bin/test/fake_process_manager.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ class StringStreamConsumer implements StreamConsumer<List<int>> {
243243
}),
244244
);
245245
subscriptions.last.onDone(() => completers.last.complete(null));
246-
return Future<dynamic>.value(null);
246+
return Future<dynamic>.value();
247247
}
248248

249249
@override
@@ -254,6 +254,6 @@ class StringStreamConsumer implements StreamConsumer<List<int>> {
254254
completers.clear();
255255
streams.clear();
256256
subscriptions.clear();
257-
return Future<dynamic>.value(null);
257+
return Future<dynamic>.value();
258258
}
259259
}

packages/diagram_generator/lib/main.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ Future<void> main(List<String> args) async {
9494
AlignDiagramStep(controller),
9595
AnimationStatusValueDiagramStep(controller),
9696
AppBarDiagramStep(controller),
97+
ArcDiagramStep(controller),
9798
BlendModeDiagramStep(controller),
9899
BottomNavigationBarDiagramStep(controller),
99100
BoxDecorationDiagramStep(controller),

packages/diagrams/lib/diagrams.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ export 'src/align.dart';
1010
export 'src/animation_diagram.dart';
1111
export 'src/animation_status_value.dart';
1212
export 'src/app_bar.dart';
13+
export 'src/arc_diagram.dart';
1314
export 'src/blend_mode.dart';
1415
export 'src/bottom_navigation_bar.dart';
1516
export 'src/box_decoration.dart';

0 commit comments

Comments
 (0)