Skip to content

Add kill signal logic to exec #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Add kill signal logic to exec #2482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e36846e
Add kill signal logic to exec
samtstern Jul 22, 2020
09a2e80
Unused
samtstern Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fixes issue where `Authorization` header was missing from callable functions in the emulator (#2459).
- Improve support for the Node.js 12 (Beta) runtime in the Functions emulator.
- Allow specifying the config (`firebase.json`) file using the `--config`/`-c` flag.
- Fixes issue where `emulators:exec` could fail to shut down cleanly (#2477).
1 change: 1 addition & 0 deletions src/emulator/commandUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ async function runScript(script: string, extraEnv: Record<string, string>): Prom
* @param options: A Commander options object.
*/
export async function emulatorExec(script: string, options: any) {
shutdownWhenKilled(options);
const projectId = getProjectId(options, true);
const extraEnv: Record<string, string> = {};
if (projectId) {
Expand Down