Skip to content

Conversation

@samtstern
Copy link
Contributor

Description

Fixes #2477

Scenarios Tested

$ firebase emulators:exec "cat"
i  emulators: Starting emulators: firestore
⚠  firestore: Did not find a Cloud Firestore rules file specified in a firebase.json config file.
⚠  firestore: The emulator will default to allowing all reads and writes. Learn more about this option: https://firebase.google.com/docs/emulator-suite/install_and_configure#security_rules_configuration.
i  firestore: Firestore Emulator logging to firestore-debug.log
^C 
i  emulators: Received SIGINT (Ctrl-C) for the first time. Starting a clean shutdown.
i  emulators: Please wait for a clean shutdown or send the SIGINT (Ctrl-C) signal again to stop right now.
i  emulators: Shutting down emulators.
i  hub: Stopping emulator hub
i  firestore: Stopping Firestore Emulator

Sample Commands

N/A

@samtstern samtstern requested a review from yuchenshi July 22, 2020 15:19
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Jul 22, 2020
@samtstern samtstern merged commit 2441e5d into master Jul 23, 2020
@bkendall bkendall deleted the ss-fix-2477 branch August 4, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emulators are not correctly terminated when firebase emulators:exec subprocess is killed

3 participants