Skip to content

Ban xit and xdescribe (and suppress existing violations). #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2018
Merged

Ban xit and xdescribe (and suppress existing violations). #725

merged 1 commit into from
Apr 25, 2018

Conversation

@mikelehen
Copy link
Contributor

@mikelehen mikelehen commented Apr 25, 2018

No description provided.

@mikelehen mikelehen requested a review from wilhuff as a code owner April 25, 2018 18:26
@mikelehen mikelehen merged commit 0e141c0 into master Apr 25, 2018
@mikelehen mikelehen deleted the mikelehen/ban-xit branch April 25, 2018 18:54
@firebase firebase locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wilhuff wilhuff Awaiting requested review from wilhuff

1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@schmidt-sebastian schmidt-sebastian

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikelehen @schmidt-sebastian @google-oss-bot