Ban xit and xdescribe (and suppress existing violations). (#725)

Author: mikelehen

packages/firestore/test/integration/api/database.test.ts

@@ -419,7 +419,8 @@ apiDescribe('Database', persistence => {
   // TODO(mikelehen): We need a way to create a query that will pass
   // client-side validation but fail remotely.  May need to wait until we
   // have security rules support or something?
-  xdescribe('Listens are rejected remotely:', () => {
+  // tslint:disable-next-line:ban
+  describe.skip('Listens are rejected remotely:', () => {
     const queryForRejection = query('foo');
 
     it('will reject listens', () => {

packages/firestore/test/integration/api/smoke.test.ts

@@ -141,7 +141,8 @@ apiDescribe('Smoke Test', persistence => {
 
   // TODO (b/33691136): temporarily disable failed test
   // This broken because it requires a composite index on filter,sort
-  xit('can query by field and use order by', () => {
+  // tslint:disable-next-line:ban
+  it.skip('can query by field and use order by', () => {
     const testDocs = {
       '1': { sort: 1, filter: true, key: '1' },
       '2': { sort: 2, filter: true, key: '2' },

packages/firestore/test/unit/remote/node/serializer.test.ts

@@ -600,8 +600,8 @@ describe('Serializer', () => {
   describe('toDocumentMask', () => {
     addEqualityMatcher();
 
-    // TODO(b/34988481): Implement correct escaping.
-    xit('converts a weird path', () => {
+    // tslint:disable-next-line:ban TODO(b/34988481): Implement correct escaping
+    it.skip('converts a weird path', () => {
       const expected: api.DocumentMask = { fieldPaths: ['foo.`bar.baz\\qux`'] };
       const mask = new FieldMask([
         FieldPath.fromServerFormat('foo.bar\\.baz\\\\qux')
@@ -614,8 +614,8 @@ describe('Serializer', () => {
   describe('fromDocumentMask', () => {
     addEqualityMatcher();
 
-    // TODO(b/34988481): Implement correct escaping.
-    xit('converts a weird path', () => {
+    // tslint:disable-next-line:ban TODO(b/34988481): Implement correct escaping
+    it.skip('converts a weird path', () => {
       const expected = new FieldMask([
         FieldPath.fromServerFormat('foo.bar\\.baz\\\\qux')
       ]);

packages/firestore/test/unit/util/sorted_map.test.ts

@@ -287,8 +287,8 @@ describe('SortedMap Tests', () => {
     expect(map.size).to.equal(0);
   });
 
-  // A little perf test for convenient benchmarking.
-  xit('Perf', () => {
+  // tslint:disable-next-line:ban A little perf test for convenient benchmarking
+  it.skip('Perf', () => {
     for (let j = 0; j < 5; j++) {
       let map = new SortedMap(primitiveComparator);
       const start = new Date().getTime();
@@ -305,7 +305,8 @@ describe('SortedMap Tests', () => {
     }
   });
 
-  xit('Perf: Insertion and removal with various # of items.', () => {
+  // tslint:disable-next-line:ban A little perf test for convenient benchmarking
+  it.skip('Perf: Insertion and removal with various # of items.', () => {
     const verifyTraversal = (map: SortedMap<number, number>, max: number) => {
       let next = 0;
       map.inorderTraversal((key: number, value: number) => {
@@ -348,7 +349,8 @@ describe('SortedMap Tests', () => {
     }
   });
 
-  xit('Perf: Comparison with {}: Insertion and removal with various # of items.', () => {
+  // tslint:disable-next-line:ban A little perf test for convenient benchmarking
+  it.skip('Perf: Comparison with {}: Insertion and removal with various # of items.', () => {
     const verifyTraversal = (tree: { [key: number]: number }, max: number) => {
       const keys: number[] = [];
       obj.forEach(tree, k => keys.push(Number(k)));

packages/firestore/tslint.json

@@ -7,6 +7,8 @@
       {"name": ["it", "only"]},
       {"name": ["describe", "skip"]},
       {"name": ["describe", "only"]},
+      {"name": ["xit"]},
+      {"name": ["xdescribe"]},
       {"name": "parseInt", "message": "tsstyle#type-coercion"},
       {"name": "parseFloat", "message": "tsstyle#type-coercion"},
       {"name": "Array", "message": "tsstyle#array-constructor"}