Skip to content

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Sep 28, 2023

dSYM upload script not working with XCode 15 archive, inspected derived data a bit. When archive a build, your application binary has an alias under $(BUILT_PRODUCTS_DIR)/$(UNLOCALIZED_RESOURCES_FOLDER_PATH), but the real application binary is created within a folder called InstallationBuildProductsLocation/ and it gets deleted once your application finishes build. Change directory from BUILT_PRODUCTS_DIR to TARGET_BUILD_DIR to get correctly binary path. Related to issue #11836
Screenshot 2023-09-27 at 5 20 37 PM

Build:
Screenshot 2023-09-28 at 4 27 21 PM
Screenshot 2023-09-28 at 4 21 47 PM

Archive:
Screenshot 2023-09-28 at 4 24 43 PM
Screenshot 2023-09-28 at 4 21 56 PM

Copy link
Contributor

@visumickey visumickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I assume this is broken only starting XCode 15. Have been able to validate this change on older XCode versions? Basically looking for the availability of the TargetBuildDir in the previous versions of XCode.

@themiswang
Copy link
Contributor Author

themiswang commented Oct 2, 2023

The changes look good to me. I assume this is broken only starting XCode 15. Have been able to validate this change on older XCode versions? Basically looking for the availability of the TargetBuildDir in the previous versions of XCode.

Yes, I checked XCode 14.3.1 and the change does not break the previous version. In fact the current implementation does not work on previous version either if you have user run script sandboxing enabled. And the reason it starts reflect on xcode 15 is because they have default sandboxing to true instead of false previously.

@themiswang themiswang merged commit 6a60408 into master Oct 2, 2023
@themiswang themiswang deleted the uploadSymbolsInputFilelist branch October 2, 2023 18:29
@firebase firebase locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants