Skip to content

Firestore: FIRQueryTests.mm: add a test that resumes a query with existence filter #10974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 2, 2023
Merged

Firestore: FIRQueryTests.mm: add a test that resumes a query with existence filter #10974

merged 9 commits into from
May 2, 2023

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Mar 20, 2023 •
edited
Loading

This is a port of firebase/firebase-js-sdk#7134

The port to the Android SDK is firebase/firebase-android-sdk#4799

#no-changelog

@dconeybe dconeybe self-assigned this Mar 20, 2023
@dconeybe dconeybe mentioned this pull request Mar 20, 2023
Merged
@google-oss-bot
Copy link

google-oss-bot commented Mar 20, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.00% (216956f) to 88.07% (2cd8062) by +0.07%.

    FilenameBase (216956f)Merge (2cd8062)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.63%-0.20%
    leveldb_remote_document_cache.cc96.41%94.61%-1.80%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4L8FfYrZI8.html

@dconeybe dconeybe force-pushed the dconeybe/QueryExistenceFilterTest branch from 15096dc to b8a9c80 Compare March 22, 2023 04:53
@dconeybe dconeybe marked this pull request as ready for review March 22, 2023 18:03
@dconeybe dconeybe requested a review from milaGGL March 22, 2023 18:03
milaGGL
milaGGL reviewed Mar 23, 2023
View reviewed changes
@dconeybe dconeybe mentioned this pull request Apr 27, 2023
Merged
@google-oss-bot
Copy link

google-oss-bot commented Apr 27, 2023

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (19ed789)Merge (d9a0942)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8GQe94o6su.html

@dconeybe dconeybe requested a review from milaGGL April 27, 2023 17:14
@dconeybe dconeybe mentioned this pull request Apr 28, 2023
Merged
milaGGL
milaGGL approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 0c58855 into master May 2, 2023
@dconeybe dconeybe deleted the dconeybe/QueryExistenceFilterTest branch May 2, 2023 15:32
andrewheard pushed a commit that referenced this pull request May 3, 2023
@dconeybe @andrewheard
Firestore: FIRQueryTests.mm: add a test that resumes a query with exi…
3ed8ea3 
…stence filter (#10974)
@firebase firebase locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @google-oss-bot @milaGGL