Skip to content

Commit 15096dc

Browse files
committed
finished the test
1 parent fb8ffc3 commit 15096dc

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Firestore/Example/Tests/Integration/API/FIRQueryTests.mm

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,12 +1211,13 @@ - (void)testResumingAQueryShouldUseExistenceFilterToDetectDeletes {
12111211
}
12121212
createdDocuments = [createdDocumentsAccumulator copy];
12131213
}
1214+
XCTAssertEqual(createdDocuments.count, 100, @"createdDocuments has the wrong size");
12141215

12151216
// Delete 50 of the 100 documents. Do this in a transaction, rather than
12161217
// [FIRDocumentReference deleteDocument], to avoid affecting the local cache.
12171218
NSSet<NSString*>* deletedDocumentIds;
12181219
{
1219-
NSMutableSet<NSString*>* deletedDocumentIdsAccumulator = [[NSMutableSet alloc] init];
1220+
NSMutableArray<NSString*>* deletedDocumentIdsAccumulator = [[NSMutableArray alloc] init];
12201221
deletedDocumentIds = [deletedDocumentIdsAccumulator copy];
12211222
XCTestExpectation *expectation = [self expectationWithDescription:@"DeleteTransaction"];
12221223
[collRef.firestore runTransactionWithBlock:
@@ -1234,7 +1235,9 @@ - (void)testResumingAQueryShouldUseExistenceFilterToDetectDeletes {
12341235
}
12351236
];
12361237
[self awaitExpectation:expectation];
1238+
deletedDocumentIds = [NSSet setWithArray:deletedDocumentIdsAccumulator];
12371239
}
1240+
XCTAssertEqual(deletedDocumentIds.count, 50, @"deletedDocumentIds has the wrong size");
12381241

12391242
// Wait for 10 seconds, during which Watch will stop tracking the query and will send an existence
12401243
// filter rather than "delete" events when the query is resumed.
@@ -1252,26 +1255,26 @@ - (void)testResumingAQueryShouldUseExistenceFilterToDetectDeletes {
12521255
if (!([FSTIntegrationTestCase isRunningAgainstEmulator] && querySnapshot2.count == 100)) {
12531256
NSSet<NSString*>* actualDocumentIds;
12541257
{
1255-
NSMutableSet<NSString*>* actualDocumentIdsAccumulator = [[NSMutableSet alloc] init];
1258+
NSMutableArray<NSString*>* actualDocumentIdsAccumulator = [[NSMutableArray alloc] init];
12561259
for (FIRDocumentSnapshot* documentSnapshot in querySnapshot2.documents) {
12571260
[actualDocumentIdsAccumulator addObject:documentSnapshot.documentID];
12581261
}
1259-
actualDocumentIds = [actualDocumentIdsAccumulator copy];
1262+
actualDocumentIds = [NSSet setWithArray:actualDocumentIdsAccumulator];
12601263
}
12611264
NSSet<NSString*>* expectedDocumentIds;
12621265
{
1263-
NSMutableSet<NSString*>* expectedDocumentIdsAccumulator = [[NSMutableSet alloc] init];
1266+
NSMutableArray<NSString*>* expectedDocumentIdsAccumulator = [[NSMutableArray alloc] init];
12641267
for (FIRDocumentReference* documentRef in createdDocuments) {
12651268
if (![deletedDocumentIds containsObject:documentRef.documentID]) {
12661269
[expectedDocumentIdsAccumulator addObject:documentRef.documentID];
12671270
}
12681271
}
1269-
expectedDocumentIds = [expectedDocumentIdsAccumulator copy];
1272+
expectedDocumentIds = [NSSet setWithArray:expectedDocumentIdsAccumulator];
12701273
}
12711274
if (! [actualDocumentIds isEqualToSet:expectedDocumentIds]) {
12721275
NSArray<NSString*>* unexpectedDocumentIds = SortedStringsNotIn(actualDocumentIds, expectedDocumentIds);
12731276
NSArray<NSString*>* missingDocumentIds = SortedStringsNotIn(expectedDocumentIds, actualDocumentIds);
1274-
XCTFail(@"The snapshot contained %@ documents (expected %@), %@ unexpected and %@ missing", @(actualDocumentIds.count), @(expectedDocumentIds.count), @(unexpectedDocumentIds.count), @(missingDocumentIds.count));
1277+
XCTFail(@"The snapshot contained %@ documents (expected %@): %@ unexpected and %@ missing; unexpected documents: %@; missing documents: %@", @(actualDocumentIds.count), @(expectedDocumentIds.count), @(unexpectedDocumentIds.count), @(missingDocumentIds.count), [unexpectedDocumentIds componentsJoinedByString:@", "], [missingDocumentIds componentsJoinedByString:@", "]);
12751278
}
12761279
}
12771280
}

0 commit comments

Comments
 (0)