Skip to content

Make pod header public so unity can build #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Make pod header public so unity can build #701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a5bc2b
Make pod header public so unity can build
Oct 6, 2021
369fc93
add comments
Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ios_pod/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ function(setup_pod_headers target_name)
# Add pod name twice as some frameworks moved includes inside a folder with
# the pod name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to add a comment along the lines of:
Link the Pods publicly, so that dependent libraries can access the necessary header files as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

target_include_directories(${target_name}
PRIVATE
# Link the Pods publicly, so that dependent libraries can access the necessary header files as well.
# Same for the below workaround.
PUBLIC
${FIREBASE_POD_HEADER_DIR}/${pod}
${FIREBASE_POD_HEADER_DIR}/${pod}/${pod}
)
Expand All @@ -90,7 +92,7 @@ function(setup_pod_headers target_name)
# we need to include the top-level Private directory as a header path. This only affects Firestore at the moment, as
# no other C++ library includes a private Pod header.
target_include_directories(${target_name}
PRIVATE
PUBLIC
${FIREBASE_POD_PRIVATE_HEADER_DIR}/
${FIREBASE_POD_PRIVATE_HEADER_DIR}/${pod}
${FIREBASE_POD_PRIVATE_HEADER_DIR}/${pod}/${pod}
Expand Down