Make pod header public so unity can build #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
approved these changes
Oct 6, 2021
| if(NOT "${SETUP_POD_HEADERS_POD_NAMES}" STREQUAL "") | ||
| foreach (pod ${SETUP_POD_HEADERS_POD_NAMES}) | ||
| # Add pod name twice as some frameworks moved includes inside a folder with | ||
| # the pod name |
There was a problem hiding this comment.
It'd be good to add a comment along the lines of:
Link the Pods publicly, so that dependent libraries can access the necessary header files as well.
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @cynthiajoan on commit ae8c32e
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the ios_pod/CMakeLists.txt, so in unity sdk firestore can build on ios
Type of Change
Place an
xthe applicable box: