Skip to content

Reading FCM error code from details section #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Reading FCM error code from details section #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions messaging/messaging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,11 @@ type fcmResponse struct {

type fcmError struct {
Error struct {
Status string `json:"status"`
Status string `json:"status"`
Details []struct {
Type string `json:"@type"`
ErrorCode string `json:"errorCode"`
}
} `json:"error"`
}

Expand Down Expand Up @@ -422,7 +426,17 @@ func (c *Client) makeSendRequest(ctx context.Context, req *fcmRequest) (string,

var fe fcmError
json.Unmarshal(resp.Body, &fe) // ignore any json parse errors at this level
msg := fcmErrorCodes[fe.Error.Status]
var code string
for _, d := range fe.Error.Details {
if d.Type == "type.googleapis.com/google.firebase.fcm.v1.FcmErrorCode" {
code = d.ErrorCode
break
}
}
if code == "" {
code = fe.Error.Status
}
msg := fcmErrorCodes[code]
if msg == "" {
msg = fmt.Sprintf("server responded with an unknown error; response: %s", string(resp.Body))
}
Expand Down
5 changes: 5 additions & 0 deletions messaging/messaging_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,11 @@ func TestSendError(t *testing.T) {
resp: "{\"error\": {\"status\": \"NOT_FOUND\", \"message\": \"test error\"}}",
want: "http error status: 500; reason: app instance has been unregistered; code: registration-token-not-registered",
},
{
resp: `{"error": {"status": "INVALID_ARGUMENT", "message": "test error", "details": [` +
`{"@type": "type.googleapis.com/google.firebase.fcm.v1.FcmErrorCode", "errorCode": "UNREGISTERED"}]}}`,
want: "http error status: 500; reason: app instance has been unregistered; code: registration-token-not-registered",
},
{
resp: "not json",
want: "http error status: 500; reason: server responded with an unknown error; response: not json",
Expand Down