Skip to content

Reading FCM error code from details section #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Reading FCM error code from details section #127

merged 1 commit into from
Mar 30, 2018

Conversation

@hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Mar 29, 2018

Porting the error handling improvement over from firebase/firebase-admin-node#246

@hiranya911 hiranya911 requested a review from avishalom March 29, 2018 17:34
@hiranya911 hiranya911 assigned hiranya911 and unassigned avishalom Mar 30, 2018
@hiranya911 hiranya911 merged commit 201a4f3 into dev Mar 30, 2018
@hiranya911 hiranya911 deleted the hkj-fcm-error branch March 30, 2018 16:37
@nordicdyno
Copy link

nordicdyno commented Mar 30, 2018

Any plans to expose Error.Details to client code? I badly need it.

@hiranya911
Copy link
Contributor Author

hiranya911 commented Mar 30, 2018

No plans to expose Error.Details. Can you explain your use case a bit more in detail? Error handling in the Go SDK is about to undergo some changes, and we can consider new requirements when we get to that.

@nordicdyno
Copy link

nordicdyno commented Mar 31, 2018 •
edited
Loading

I want have ability to know which kind of error is happened and process them accordingly. Simple example: group errors by type in monitoring counters.

Also it 's good Go practice to use typed errors not just simple error strings (that's ok for simple programs, but not for public APIs).

@hiranya911
Copy link
Contributor Author

hiranya911 commented Mar 31, 2018

That's the direction we are heading. But I can't comment on the timeline yet.

@nordicdyno
Copy link

nordicdyno commented Mar 31, 2018

Nice! I'm glad to hear that. Right now I can patch library code by myself, but it would be much better to avoid it when API improved.

hiranya911 added a commit that referenced this pull request Apr 17, 2018
@hiranya911
Release 2.7.0 (#135)
7f0a0da 
* Changlog updates (#123)

* Reading FCM error code from details section (#127)

* Adding additional details to the error message when available (#129)

* Implementing support for APNS content-mutable field (#126)

* Implementing support for APNS content-mutable field

* Corrected the mutable-content option name

* Renamed CustomFields to CustomData

* Added comment

* Implementing Functions to Test Error Codes (#131)

* Adding error codes to the auth package

* Added error codes for messaging

* Responding to review feedback; Updated changelog

* Add Go import comments. (#132)

* Bumped version to 2.7.0 (#133)

* Bumped version to 2.7.0

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@avishalom avishalom avishalom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiranya911 @nordicdyno @avishalom