Skip to content

Separate interactive dismissal and cancel button customization #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix: respects DarkMode in CountryTableView
merged 1 commit into from
Oct 21, 2019
Merged

Separate interactive dismissal and cancel button customization #792

merged 1 commit into from
Oct 21, 2019

Conversation

@morganchen12
Copy link
Contributor

Fixes #789.

@morganchen12 morganchen12 mentioned this pull request Oct 18, 2019
Closed
borut-t
borut-t approved these changes Oct 21, 2019
View reviewed changes
Copy link

@borut-t borut-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganchen12 this solution works for me 🙌

@morganchen12 morganchen12 merged commit dbd9c5b into master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@borut-t borut-t borut-t approved these changes

@renkelvin renkelvin renkelvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing and broken behavior of interactive dismissal on iOS 13

4 participants

@morganchen12 @borut-t @renkelvin @googlebot