Skip to content

Conversation

@matheusmatos
Copy link
Contributor

Hello guys, this simple PR fixes the issue #1013.

<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="14790.5"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="21678"/>
<capability name="System colors in document resources" minToolsVersion="11.0"/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed automatically by xCode.

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@morganchen12 morganchen12 self-assigned this May 31, 2023
@RaimundasSakalauskas
Copy link

Any estimation when this might get merged and shipped? Our users keep complaining about unusable country selector in dark mode.

@tehsven
Copy link

tehsven commented Aug 11, 2023

Hey @matheusmatos can you please hit the Merge button? This continues to be an issue and we're having to workaround it with some pretty hacky code.

@tehsven
Copy link

tehsven commented Aug 11, 2023

Or maybe @morganchen12 can merge this?

@vinhhoangbepos
Copy link

@morganchen12 @matheusmatos Can you please merge this?

@RaimundasSakalauskas
Copy link

Since google team seems to be ignoring this entirely, here's the workaround that we have to make this work:

private var phoneAuthUIBugTask: Task<Void, Error>?
...
            if button.provider.providerID == PhoneAuthProviderID {
                phoneAuthUIBugTask = Task { @MainActor [weak self] in
                    while let self, self.presentedViewController != nil {
                        if let nvc = self.presentedViewController as? UINavigationController,
                           nvc.viewControllers.count >= 2, case let vc = nvc.viewControllers[1],
                           vc.view.subviews.count >= 1, let tableView = vc.view.subviews[0] as? UITableView {
                            tableView.backgroundColor = .systemBackground //fix dark mode
                            tableView.tableHeaderView = nil //remove search view, because it's broken
                        }
                        
                        //10x per second
                        try await Task.sleep(nanoseconds: 100_000_000)
                    }
                }
            }
...

I start the task when displaying the phone auth and cancel the task in func authUI(_ authUI: FUIAuth, didSignInWith authDataResult: AuthDataResult?, error: Error?)

@morganchen12 morganchen12 merged commit 51d78ac into firebase:master Nov 7, 2023
@morganchen12
Copy link
Contributor

Hey everyone, apologies for the slow merge. This will be out in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants