Skip to content

do not use try-catch in the example #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2018
Merged

do not use try-catch in the example #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,14 @@ fastify.register(require('fastify-postgres'), {
})

fastify.post('/user/:username', (req, reply) => {
Copy link
Contributor

@cemremengu cemremengu Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we make this async, we can directly return return client.query right?

Copy link
Member Author

@mcollina mcollina Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to use async at all because Fastify understand promises. However that won't be the normal case for applications.

Copy link
Contributor

@cemremengu cemremengu Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thank you for the info!

fastify.pg.transact(async client => {
try {
const id = await client.query('INSERT INTO users(username) VALUES($1) RETURNING id', [req.params.username])
reply.send(id)
} catch (err) {
reply.send(err)
}
// will return a promise, fastify will send the result automatically
return fastify.pg.transact(async client => {
// will resolve to an id, or reject with an error
const id = await client.query('INSERT INTO users(username) VALUES($1) RETURNING id', [req.params.username])

// potentially do something with id

return id
})
})

Expand Down