do not use try-catch in the example #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemremengu
approved these changes
Oct 4, 2018
| connectionString: 'postgres://postgres@localhost/postgres' | ||
| }) | ||
|
|
||
| fastify.post('/user/:username', (req, reply) => { |
There was a problem hiding this comment.
If we make this async, we can directly return return client.query right?
There was a problem hiding this comment.
There is no need to use async at all because Fastify understand promises. However that won't be the normal case for applications.
There was a problem hiding this comment.
Ah yes, thank you for the info!
mcollina
force-pushed
the
update-example
branch
from
e83e2c4 to
e394f7a
Compare
|
@mcollina FYI I can't merge this one |
|
You can now, and you should be able to release as well :) |
|
Thank you! :) this will be a semver minor right? |
|
patch! |
|
Ok so publishing only readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, I think the example could be simplified a lot.
This has the benefit to potentially avoid unhandled rejections