Add WebSocket host constraints #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mcollina merged 3 commits into fastify:master from valeneiko:websocket-routing

Jan 30, 2024

Contributor

valeneiko commented Jan 22, 2024

Fixes 2 issues:

mismatch between Http and WebSocket routing
- WebSockets now support constraints
- WebSockets now use the same path rewriting logic as Http
wsServerOptions are now distinct for each WebSocket proxy

Fixes: #206

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

valeneiko and others added 3 commits

January 22, 2024 19:11


          Add WebSocket host constraints

01f48d8


          Make sure query params are included in WebSocket request

91dfcbc


          Send some dummy messages to make WebSockets close properly on Windows

4cd7cc5

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

mcollina merged commit 916d85c into fastify:master

renovate bot referenced this pull request in redwoodjs/graphql


          fix(deps): update dependency @fastify/http-proxy to v9.4.0 (#10091)

f1a8cd8

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/http-proxy](https://github.com/fastify/fastify-http-proxy)
| [`9.3.0` ->
`9.4.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-http-proxy
(@&#8203;fastify/http-proxy)</summary>

###
[`v9.4.0`](https://github.com/fastify/fastify-http-proxy/releases/tag/v9.4.0)

[Compare
Source](https://github.com/fastify/fastify-http-proxy/compare/v9.3.0...v9.4.0)

#### What's Changed

- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-http-proxy/pull/328](https://github.com/fastify/fastify-http-proxy/pull/328)
- chore: replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-http-proxy/pull/331](https://github.com/fastify/fastify-http-proxy/pull/331)
- Add WebSocket host constraints by
[@&#8203;valeneiko](https://github.com/valeneiko) in
[https://github.com/fastify/fastify-http-proxy/pull/332](https://github.com/fastify/fastify-http-proxy/pull/332)

#### New Contributors

- [@&#8203;valeneiko](https://github.com/valeneiko) made their first
contribution in
[https://github.com/fastify/fastify-http-proxy/pull/332](https://github.com/fastify/fastify-http-proxy/pull/332)

**Full Changelog**:
fastify/fastify-http-proxy@v9.3.0...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominic Saadi <[email protected]>

jtoar referenced this pull request in redwoodjs/graphql


          fix(deps): update dependency @fastify/http-proxy to v9.4.0 (#10091)

92b933d

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@fastify/http-proxy](https://github.com/fastify/fastify-http-proxy)
| [`9.3.0` ->
`9.4.0`](https://renovatebot.com/diffs/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fhttp-proxy/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fhttp-proxy/9.3.0/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify-http-proxy
(@&#8203;fastify/http-proxy)</summary>

###
[`v9.4.0`](https://github.com/fastify/fastify-http-proxy/releases/tag/v9.4.0)

[Compare
Source](https://github.com/fastify/fastify-http-proxy/compare/v9.3.0...v9.4.0)

#### What's Changed

- build(deps-dev): bump tsd from 0.29.0 to 0.30.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/fastify/fastify-http-proxy/pull/328](https://github.com/fastify/fastify-http-proxy/pull/328)
- chore: replace `fastify.io` links with `fastify.dev` by
[@&#8203;Fdawgs](https://github.com/Fdawgs) in
[https://github.com/fastify/fastify-http-proxy/pull/331](https://github.com/fastify/fastify-http-proxy/pull/331)
- Add WebSocket host constraints by
[@&#8203;valeneiko](https://github.com/valeneiko) in
[https://github.com/fastify/fastify-http-proxy/pull/332](https://github.com/fastify/fastify-http-proxy/pull/332)

#### New Contributors

- [@&#8203;valeneiko](https://github.com/valeneiko) made their first
contribution in
[https://github.com/fastify/fastify-http-proxy/pull/332](https://github.com/fastify/fastify-http-proxy/pull/332)

**Full Changelog**:
fastify/fastify-http-proxy@v9.3.0...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominic Saadi <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet