Skip to content

Fix SerializerCompiler type #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Fix SerializerCompiler type #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0d3232
Fix SerializerCompiler type
remidewitte Apr 3, 2024
354c25e
Merge branch 'main' into fix-type-SerializerCompiler
Uzlopak Dec 8, 2024
ec13180
fix linting
Uzlopak Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ declare namespace SerializerSelector {
options?: Options
) => SerializerCompiler;

export type SerializerCompiler = (
externalSchemas?: unknown,
options?: Options
) => Serializer;
export type SerializerCompiler = (routeDef: RouteDefinition) => Serializer;

export type Serializer = (doc: any) => string

Expand Down
5 changes: 4 additions & 1 deletion types/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import SerializerSelector, {
expectType<SerializerFactory>(factory);
const compiler = factory(externalSchemas1, {})
expectType<SerializerCompiler>(compiler);
const serializeFunc = compiler({ schema: sampleSchema })
const serializeFunc = compiler({ schema: sampleSchema, method: '', url:'', httpStatus: '' })
expectType<Serializer>(serializeFunc);

expectType<string>(serializeFunc({ name: 'hello' }))
Expand Down Expand Up @@ -88,6 +88,9 @@ expectType<SerializerFactory>(writer);
}

const endpointSchema = {
method: '',
url: '',
httpStatus: '',
schema: {
$id: 'urn:schema:endpoint',
$ref: 'urn:schema:ref'
Expand Down