-
Notifications
You must be signed in to change notification settings - Fork 49.4k
[ci] Add polling to download-build-artifacts #30515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 29, 2024
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 6 minutes for the build for that revision to complete. ghstack-source-id: 2176d7f Pull Request resolved: #30515
Comparing: 6b82f3c...7108e0a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 6 minutes for the build for that revision to complete. ghstack-source-id: f7a4854 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 6 minutes for the build for that revision to complete. ghstack-source-id: 6e0b685 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 513e133 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 409c79c Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: f95640d Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: c6d3d0e Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 886c6b8 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 6a95463 Pull Request resolved: #30515
poteto
added a commit
that referenced
this pull request
Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow to complete before it can successfully download the build artifact. However it is possible to encounter a race condition where the build hasn't completed when the new workflow is started. This PR adds a simple polling mechanism that waits up to 10 minutes for the build for that revision to complete. ghstack-source-id: 6a95463 Pull Request resolved: #30515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.
This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.