Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 29, 2024

Stack from ghstack (oldest at bottom):

Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:57pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 29, 2024
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.

ghstack-source-id: 2176d7f
Pull Request resolved: #30515
@react-sizebot
Copy link

react-sizebot commented Jul 29, 2024

Comparing: 6b82f3c...7108e0a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.59 kB 508.59 kB = 91.15 kB 91.15 kB
facebook-www/ReactDOM-prod.classic.js = 596.53 kB 596.53 kB = 105.80 kB 105.80 kB
facebook-www/ReactDOM-prod.modern.js = 572.82 kB 572.82 kB = 102.01 kB 102.01 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-profiling.fb.js = 391.88 kB 390.86 kB = 68.44 kB 68.23 kB
react-native/implementations/ReactFabric-prod.fb.js = 364.38 kB 363.34 kB = 64.14 kB 63.98 kB

Generated by 🚫 dangerJS against 99acd4f

[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.

ghstack-source-id: f7a4854
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 6 minutes for
the build for that revision to complete.

ghstack-source-id: 6e0b685
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: 513e133
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: 409c79c
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: f95640d
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: c6d3d0e
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: 886c6b8
Pull Request resolved: #30515
[ghstack-poisoned]
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: 6a95463
Pull Request resolved: #30515
@poteto poteto merged commit 99acd4f into gh/poteto/8/base Jul 29, 2024
poteto added a commit that referenced this pull request Jul 29, 2024
Several CI workflows depend on the runtime_build_and_test.yml workflow
to complete before it can successfully download the build artifact.
However it is possible to encounter a race condition where the build
hasn't completed when the new workflow is started.

This PR adds a simple polling mechanism that waits up to 10 minutes for
the build for that revision to complete.

ghstack-source-id: 6a95463
Pull Request resolved: #30515
@poteto poteto deleted the gh/poteto/8/head branch July 29, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants