Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Jul 29, 2024

Stack from ghstack (oldest at bottom):

actions/cache has a default timeout of 10 minutes. Occasionally the
cache service download gets stuck and it waits this amount of time
before proceeding like it was a cache miss.

10 minutes is way too long so let's shorten this to a minute.

[ghstack-poisoned]
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 9:26pm

poteto added a commit that referenced this pull request Jul 29, 2024
actions/cache has a default timeout of 10 minutes. Occasionally the
cache service download gets stuck and it waits this amount of time
before proceeding like it was a cache miss.

10 minutes is way too long so let's shorten this to a minute.

ghstack-source-id: b316196
Pull Request resolved: #30512
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jul 29, 2024
[ghstack-poisoned]
@react-sizebot
Copy link

react-sizebot commented Jul 29, 2024

Comparing: 397646a...ec2ae2b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.59 kB 508.59 kB = 91.15 kB 91.15 kB
facebook-www/ReactDOM-prod.classic.js = 596.53 kB 596.53 kB = 105.80 kB 105.80 kB
facebook-www/ReactDOM-prod.modern.js = 572.82 kB 572.82 kB = 102.01 kB 102.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1594542

[ghstack-poisoned]
@poteto poteto merged commit 1594542 into gh/poteto/7/base Jul 29, 2024
poteto added a commit that referenced this pull request Jul 29, 2024
actions/cache has a default timeout of 10 minutes. Occasionally the
cache service download gets stuck and it waits this amount of time
before proceeding like it was a cache miss.

10 minutes is way too long so let's shorten this to a minute.

ghstack-source-id: 95dee31
Pull Request resolved: #30512
@poteto poteto deleted the gh/poteto/7/head branch July 29, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants