clean: remove ConsoleContext entirely by using buildStart
#414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the only reason that `ConsoleContext` was still used was because the `options` hook doesn't support certain context functions like `this.error` / `this.warn` etc
- but `buildStart` does! so we can just move pretty much everything into `buildStart` instead
- didn't move setting `rollupOptions` because that value gets hashed and the value in `buildStart` is different, as it is after all plugins' `options` hooks have ran
- this way we don't need `ConsoleContext` what-so-ever and so can remove it entirely!
- as well as `IContext`, its tests, etc
- use `this.error` instead of `throw`ing errors in `parse-tsconfig` as it exists now
- couldn't in the `options` hook, can in `buildStart`
- this also ensure we don't have all the `rpt2: ` prefixes ever missing again
- c.f. ff88951, 0628482
- refactor `parse-tsconfig.spec` to account for this change
- c.f. Rollup hooks docs: https://rollupjs.org/guide/en/#options, https://rollupjs.org/guide/en/#buildstart
agilgur5
added
the
kind: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
ConsoleContext(and the need for it) by using thebuildStarthook instead of theoptionshookincluded files missed bytransform(type-only files) #345 (comment)Details
the only reason that
ConsoleContextwas still used was because theoptionshook doesn't support certain context functions likethis.error/this.warnetcbuildStartdoes! so we can just move pretty much everything intobuildStartinsteadrollupOptionsbecause that value gets hashed and the value inbuildStartis different, as it is after all plugins'optionshooks have ranConsoleContextwhat-so-ever and so can remove it entirely!IContext, its tests, etcuse
this.errorinstead ofthrowing errors inparse-tsconfigas it exists nowoptionshook, can inbuildStartrpt2:prefixes ever missing againparse-tsconfig.specto account for this change