dx: add rpt2 prefix to remaining errors #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- most were added in ff88951, but these two were missed - this should now cover all **thrown** errors - they only get thrown in the `options` hook, which does not implement Rollup's `this.error` - all other errors are already auto-prefixed by RollupContext etc
|
Tests are failing due to #377 ; the ones that check these changed error messages still pass |
agilgur5
added
kind: dx
agilgur5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
rpt2:prefix to remaining, unprefixed error messagesDetails
most were added in ff88951, but these two were missed
this should now cover all thrown errors
optionshook, which does not implement Rollup'sthis.error