acronym: Update and exclude new tests #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might want to consider supporting the "excluded_tests" pattern in the base ExerciseCase so it can be easily be used by other generators.
kotp
approved these changes
Mar 29, 2019
Member
|
Note #935 though. |
emcoding
approved these changes
Mar 29, 2019
Contributor
emcoding
left a comment
emcoding
left a comment
There was a problem hiding this comment.
Awesome!
(935 is not applicable here)
pgaspar
changed the title
kotp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR was initially merged and reverted (#950). This new version separates the changes to the test template into its own PR (#952). This PR thus depends on PR #952.
We've recently stopped updating the Acronym exercise because of two new test cases:
test_apostrophes(introduced by Acronym: New test case for apostrophe problem-specifications#1377)test_underscore_emphasis(introduced by Acronym: add underscore test case problem-specifications#1436)This PR changes the generator to automatically exclude these two test cases. With this change we can still get updates from the canonical version without adding the tests we don't want at the same time.
If the idea of excluding certain tests proves useful we may want to consider supporting it in the base
ExerciseCaseso it can be easily be used by other generators.