Regenerate exercises #931
Closed
Regenerate exercises #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regenerates phone_number and space-age tests. They're still syntactically correct and the tests still pass for them. I've not committed acronym_test, sum_of_multiples or wordy as regenerating them breaks them. Keeping the exercises up to date is generally a good idea. I'm particuarly interested in regenerating them so I can know the effect of my other changes. I'll be upgrading the ruby version and the rubocop version. By regenerating before hand, I can more easily verify that my changes haven't changed the regeneration process. ``` ./bin/generate --all ```
emcoding
suggested changes
Jan 29, 2019
Regenerate the sum-of-multiples test case. The example solution needed fixing to incorporate the new test case.
The new test case that has a number but no operations broke the example solution. I fixed the test case by not having the regular expression require any operations.
Member
|
|
This was referenced Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to be upgrading the Ruby version.
This is going to require me to upgrade the Rubocop version.
Before I begin, I want to be able to run:
And see no failures or changed code.
This way, I can easily verify I haven't broken anything in the version upgrades.
This pull request gets the project into that good state.
I suspect regenerating the exercises is good for keeping the project fresh as well.
Only 6 exercises needed regenerating.
Phone number and space age were easy.
Gigasecond needed a change to it's generator.
Acronym needed a change to it's generator and a small change to the example solution.
Sum of multiples needed a small change to it's example solution.
Wordy needed a more involved change to it's example solution.