-
Notifications
You must be signed in to change notification settings - Fork 265
Fix dev-node #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev-node #1383
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request includes changes across several documents. In the documentation for developers, the terminology was updated from "development node" to "development network" in two instances for consistency. A metadata JSON file for operator tutorials was modified to fix a trailing comma and to add a new tutorial entry for "Running a Local Network Environment." Additionally, a new tutorial file was introduced that provides detailed instructions for setting up and running a local OP Stack development network. This tutorial covers prerequisites such as installing Docker and Kurtosis, configuring the network via a YAML file, using the Kurtosis CLI to launch the network, and steps for connecting wallets and depositing funds for interaction. Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (9)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (7)
1-5
: Frontmatter consistency check.
The frontmatter is correctly formatted. However, note that the title (“Running a Local Network Environment”) differs slightly from the main heading on line 10 (“Running a Local Development Environment”). Consider aligning these terms for consistency.
10-11
: Heading terminology alignment.
Line 10 uses “Running a Local Development Environment” whereas the title in the frontmatter uses “Local Network Environment.” Consider updating the heading to match the frontmatter terminology for consistency.
12-16
: Capitalization of proper noun “GitHub”.
In the info callout on lines 12–16, “[Github]” should be capitalized as “[GitHub]” to reflect the correct brand name.- [Github](https://github.com/ethereum-optimism/optimism). + [GitHub](https://github.com/ethereum-optimism/optimism).
20-23
: Punctuation improvement for clarity.
The sentence on lines 20–23 would read more clearly with an inserted comma after “components”. Consider revising as follows:-To learn about the different components please read the [deployment overview page](/builders/chain-operators/deploy/overview). +To learn about the different components, please read the [deployment overview page](/builders/chain-operators/deploy/overview).🧰 Tools
🪛 LanguageTool
[typographical] ~21-~21: Consider adding a comma here.
Context: ... To learn about the different components please read the [deployment overview page](/bu...(PLEASE_COMMA)
24-27
: Hyphenate compound adjective.
In line 25, consider changing “open source software” to “open‐source software” since the compound adjective is modifying “software.”-**The OP Stack is free and open source software licensed entirely under the MIT license**. +**The OP Stack is free and open-source software licensed entirely under the MIT license**.🧰 Tools
🪛 LanguageTool
[uncategorized] ~25-~25: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...r own needs. **The OP Stack is free and open source software licensed entirely under the MI...(EN_COMPOUND_ADJECTIVE_INTERNAL)
58-67
: YAML snippet indentation verification.
The provided YAML snippet appears well structured. It would be helpful to verify that the indentation aligns with YAML standards, ensuring that keys such as “participants” and “network_params” are correctly nested within the list element.
145-145
: Grammar suggestion for smoother flow.
Consider adding a comma after “At this point” on line 145 to improve the sentence flow:-At this point your chain is up and running. Let's move on to the next section to learn how to interact with it. +At this point, your chain is up and running. Let's move on to the next section to learn how to interact with it.🧰 Tools
🪛 LanguageTool
[typographical] ~145-~145: It appears that a comma is missing.
Context: ...use to connect to the service. At this point your chain is up and running. Let's mov...(DURING_THAT_TIME_COMMA)
pages/app-developers/building-apps.mdx (2)
22-23
: Comma insertion for clarity.
On line 22 the sentence would read more naturally with a comma after “For development purposes”. Consider updating it as follows:-For development purposes we recommend you use either a local development net or [OP Sepolia](https://sepolia-optimism.etherscan.io). +For development purposes, we recommend you use either a local development net or [OP Sepolia](https://sepolia-optimism.etherscan.io).🧰 Tools
🪛 LanguageTool
[uncategorized] ~22-~22: Possible missing comma found.
Context: ...s. ### Network choice For development purposes we recommend you use either a local dev...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~23-~23: Possible missing comma found.
Context: ...://sepolia-optimism.etherscan.io). That way you don't need to spend real money. If ...(AI_HYDRA_LEO_MISSING_COMMA)
54-56
: Clarify technical phrasing.
The sentence on line 55 could be made clearer. Consider rephrasing “parts that are OP Stack chains specific such as calls to bridges to transfer ETH or tokens between layers” to something like “components specific to OP Stack chains (for example, bridges used to transfer ETH or tokens between layers)”.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
pages/app-developers/building-apps.mdx
(2 hunks)pages/operators/chain-operators/tutorials/_meta.json
(1 hunks)pages/operators/chain-operators/tutorials/chain-dev-net.mdx
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- pages/operators/chain-operators/tutorials/_meta.json
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
pages/app-developers/building-apps.mdx
🪛 LanguageTool
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
[style] ~17-~17: Consider using an alternative to strengthen your wording.
Context: ...rial is designed for developers who want to learn about the OP Stack by spinning...
(WANT_KEEN)
[typographical] ~21-~21: Consider adding a comma here.
Context: ... To learn about the different components please read the [deployment overview page](/bu...
(PLEASE_COMMA)
[uncategorized] ~25-~25: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...r own needs. **The OP Stack is free and open source software licensed entirely under the MI...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~145-~145: It appears that a comma is missing.
Context: ...use to connect to the service. At this point your chain is up and running. Let's mov...
(DURING_THAT_TIME_COMMA)
[grammar] ~156-~156: This phrase is duplicated. You should probably use “test test” only once.
Context: ...re-fund development addresses using the `test test test test test test test test test test test junk...
(PHRASE_REPETITION)
pages/app-developers/building-apps.mdx
[uncategorized] ~22-~22: Possible missing comma found.
Context: ...s. ### Network choice For development purposes we recommend you use either a local dev...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (4)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (3)
7-9
: MDX imports look correct.
The component imports on lines 7–9 are appropriate for the document.
17-18
: Content clarity and emphasis.
The introduction emphasizes that the tutorial is designed for developers, which is clear and direct. No changes necessary here.🧰 Tools
🪛 LanguageTool
[style] ~17-~17: Consider using an alternative to strengthen your wording.
Context: ...rial is designed for developers who want to learn about the OP Stack by spinning...(WANT_KEEN)
156-156
: Mnemonic phrasing confirmation.
The mnemonic “test test test test test test test test test test test junk” on line 156 is the well‐known default phrase used in many Ethereum development environments. Although it appears repetitive, it is intentionally so; no change is needed.🧰 Tools
🪛 LanguageTool
[grammar] ~156-~156: This phrase is duplicated. You should probably use “test test” only once.
Context: ...re-fund development addresses using the `test test test test test test test test test test test junk...(PHRASE_REPETITION)
pages/app-developers/building-apps.mdx (1)
1-66
: Overall content and terminology update.
The updates from “development node” to “development net” have been applied consistently, and the document now aligns with the new tutorial on running a local OP Stack devnet. The content is clear and thorough.🧰 Tools
🪛 LanguageTool
[uncategorized] ~18-~18: Possible missing comma found.
Context: ...point URLs To access any Ethereum type network you need an endpoint. [These providers]...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~22-~22: Possible missing comma found.
Context: ...s. ### Network choice For development purposes we recommend you use either a local dev...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~23-~23: Possible missing comma found.
Context: ...://sepolia-optimism.etherscan.io). That way you don't need to spend real money. If ...(AI_HYDRA_LEO_MISSING_COMMA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first link in the next steps is broken, we should just remove it because we don't want to point people to op stack hacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (5)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (5)
17-19
: Wording improvement suggestion.Consider rephrasing “designed for developers” to a more direct, active phrasing such as “for developers” to improve clarity.
🧰 Tools
🪛 LanguageTool
[style] ~17-~17: Consider using an alternative to strengthen your wording.
Context: ...rial is designed for developers who want to learn about the OP Stack by spinning...(WANT_KEEN)
20-22
: Comma insertion for clarity.Add a comma after “components” in the sentence “...different components please read the [deployment overview page]…” to enhance readability.
🧰 Tools
🪛 LanguageTool
[typographical] ~21-~21: Consider adding a comma here.
Context: ... To learn about the different components please read the [deployment overview page](/op...(PLEASE_COMMA)
24-26
: Compound adjective formatting.Replace “open source software” with “open‐source software” to correctly indicate the compound adjective modifying “software.”
🧰 Tools
🪛 LanguageTool
[uncategorized] ~25-~25: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...r own needs. **The OP Stack is free and open source software licensed entirely under the MI...(EN_COMPOUND_ADJECTIVE_INTERNAL)
145-145
: Punctuation suggestion.Consider adding a comma after “up and running” in “At this point your chain is up and running. Let's move on…” to improve the sentence flow.
🧰 Tools
🪛 LanguageTool
[typographical] ~145-~145: It appears that a comma is missing.
Context: ...use to connect to the service. At this point your chain is up and running. Let's mov...(DURING_THAT_TIME_COMMA)
156-156
: Verify mnemonic repetition.The mnemonic phrase repeats “test” multiple times as in
test test test test test test test test test test test junk
Confirm that this is the intended standard development mnemonic and that the repetition is correct.
🧰 Tools
🪛 LanguageTool
[grammar] ~156-~156: This phrase is duplicated. You should probably use “test test” only once.
Context: ...re-fund development addresses using the `test test test test test test test test test test test junk...(PHRASE_REPETITION)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
🪛 LanguageTool
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
[style] ~17-~17: Consider using an alternative to strengthen your wording.
Context: ...rial is designed for developers who want to learn about the OP Stack by spinning...
(WANT_KEEN)
[typographical] ~21-~21: Consider adding a comma here.
Context: ... To learn about the different components please read the [deployment overview page](/op...
(PLEASE_COMMA)
[uncategorized] ~25-~25: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...r own needs. **The OP Stack is free and open source software licensed entirely under the MI...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~145-~145: It appears that a comma is missing.
Context: ...use to connect to the service. At this point your chain is up and running. Let's mov...
(DURING_THAT_TIME_COMMA)
[grammar] ~156-~156: This phrase is duplicated. You should probably use “test test” only once.
Context: ...re-fund development addresses using the `test test test test test test test test test test test junk...
(PHRASE_REPETITION)
🔇 Additional comments (2)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (2)
10-10
: Header case inconsistency.The H1 header “Running a Local Development Environment” should use sentence case (capitalize only the first word) instead of title case. Please change it to “Running a local development environment.”
47-50
: Consider adding a link to the Kurtosis GitHub repository.Including a link (e.g., https://github.com/kurtosis-tech/kurtosis) in this section would help users quickly access additional resources.
Co-authored-by: soyboy <[email protected]>
Co-authored-by: soyboy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
pages/operators/chain-operators/tutorials.mdx (1)
1-7
:⚠️ Potential issueMissing required frontmatter metadata.
The frontmatter lacks the requiredtopic
field, which is necessary for landing pages (those that contain<Cards>
). Please add a non-emptytopic
field to ensure complete metadata.
🧹 Nitpick comments (4)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (4)
17-17
: Wording improvement suggestion.
Consider revising “designed for developers” to a stronger alternative such as “intended for developers” to improve clarity and tone.🧰 Tools
🪛 LanguageTool
[style] ~17-~17: Consider using an alternative to strengthen your wording.
Context: ...rial is designed for developers who want to learn about the OP Stack by spinning...(WANT_KEEN)
20-22
: Punctuation correction needed.
A comma is needed to improve the readability of the sentence. For example, update:-To learn about the different components please read the [deployment overview page](/operators/chain-operators/deploy/overview). +To learn about the different components, please read the [deployment overview page](/operators/chain-operators/deploy/overview).🧰 Tools
🪛 LanguageTool
[typographical] ~21-~21: Consider adding a comma here.
Context: ... To learn about the different components please read the [deployment overview page](/op...(PLEASE_COMMA)
25-25
: Compound adjective formatting.
In the phrase “The OP Stack is free and open source software licensed entirely under the MIT license,” change “open source” to “open‐source” to correctly format the compound adjective. For example:-The OP Stack is free and open source software licensed entirely under the MIT license. +The OP Stack is free and open-source software licensed entirely under the MIT license.🧰 Tools
🪛 LanguageTool
[uncategorized] ~25-~25: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...r own needs. **The OP Stack is free and open source software licensed entirely under the MI...(EN_COMPOUND_ADJECTIVE_INTERNAL)
145-145
: Punctuation improvement.
Add a comma after “At this point” to improve the readability of the sentence. For example:-At this point your chain is up and running. +At this point, your chain is up and running.🧰 Tools
🪛 LanguageTool
[typographical] ~145-~145: It appears that a comma is missing.
Context: ...use to connect to the service. At this point your chain is up and running. Let's mov...(DURING_THAT_TIME_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
pages/app-developers/building-apps.mdx
(2 hunks)pages/operators/chain-operators/tutorials.mdx
(1 hunks)pages/operators/chain-operators/tutorials/_meta.json
(1 hunks)pages/operators/chain-operators/tutorials/chain-dev-net.mdx
(1 hunks)pages/stack/dev-net.mdx
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- pages/stack/dev-net.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
- pages/operators/chain-operators/tutorials/_meta.json
- pages/app-developers/building-apps.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. You can fix this by running:Review the changes, then run without :dry to apply them.'pnpm metadata-batch-cli:dry "path/to/this/file.mdx"
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/operators/chain-operators/tutorials.mdx
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
🪛 LanguageTool
pages/operators/chain-operators/tutorials/chain-dev-net.mdx
[style] ~17-~17: Consider using an alternative to strengthen your wording.
Context: ...rial is designed for developers who want to learn about the OP Stack by spinning...
(WANT_KEEN)
[typographical] ~21-~21: Consider adding a comma here.
Context: ... To learn about the different components please read the [deployment overview page](/op...
(PLEASE_COMMA)
[uncategorized] ~25-~25: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...r own needs. **The OP Stack is free and open source software licensed entirely under the MI...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[typographical] ~145-~145: It appears that a comma is missing.
Context: ...use to connect to the service. At this point your chain is up and running. Let's mov...
(DURING_THAT_TIME_COMMA)
[grammar] ~156-~156: This phrase is duplicated. You should probably use “test test” only once.
Context: ...re-fund development addresses using the `test test test test test test test test test test test junk...
(PHRASE_REPETITION)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (2)
pages/operators/chain-operators/tutorials/chain-dev-net.mdx (2)
1-5
: Missing required frontmatter metadata.
The frontmatter contains onlytitle
,lang
, anddescription
. For a regular tutorial page, include additional required fields such astopic
,personas
,categories
, andcontent_type
to meet the metadata standards. You can address this by running:pnpm metadata-batch-cli:dry "pages/operators/chain-operators/tutorials/chain-dev-net.mdx"
156-156
: Mnemonic phrase verification.
The mnemonic “test test test test test test test test test test test junk” is presented in full, and while it is a standard test mnemonic, please verify that its usage here is intentional and aligns with the testing protocols.🧰 Tools
🪛 LanguageTool
[grammar] ~156-~156: This phrase is duplicated. You should probably use “test test” only once.
Context: ...re-fund development addresses using the `test test test test test test test test test test test junk...(PHRASE_REPETITION)
No description provided.